From: James Smart Date: Wed, 1 Aug 2018 00:23:24 +0000 (-0700) Subject: scsi: lpfc: Remove lpfc_enable_pbde as module parameter X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=06b6fa38155ea3709f4d612ae71c201c3f179164;p=linux.git scsi: lpfc: Remove lpfc_enable_pbde as module parameter Enablement of the PBDE optimization brought out some incompatible behaviors under error scenarios. Best to disable and remove the PBDE optimization. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c index 514513f837a89..5a25553415f8b 100644 --- a/drivers/scsi/lpfc/lpfc_attr.c +++ b/drivers/scsi/lpfc/lpfc_attr.c @@ -5387,14 +5387,6 @@ LPFC_BBCR_ATTR_RW(enable_bbcr, 1, 0, 1, "Enable BBC Recovery"); */ LPFC_ATTR_RW(enable_dpp, 1, 0, 1, "Enable Direct Packet Push"); -/* - * lpfc_enable_pbde: Enable PBDE on PRISM - G7 - * 0 = PBDE on G7 disabled - * 1 = PBDE on G7 enabled (default) - * Value range is [0,1]. Default value is 1 - */ -LPFC_ATTR_R(enable_pbde, 1, 0, 1, "Enable PBDE support on PRISM"); - struct device_attribute *lpfc_hba_attrs[] = { &dev_attr_nvme_info, &dev_attr_bg_info, @@ -5506,7 +5498,6 @@ struct device_attribute *lpfc_hba_attrs[] = { &dev_attr_lpfc_enable_mds_diags, &dev_attr_lpfc_enable_bbcr, &dev_attr_lpfc_enable_dpp, - &dev_attr_lpfc_enable_pbde, NULL, }; @@ -6541,7 +6532,6 @@ lpfc_get_cfgparam(struct lpfc_hba *phba) lpfc_nvme_io_channel_init(phba, lpfc_nvme_io_channel); lpfc_enable_bbcr_init(phba, lpfc_enable_bbcr); lpfc_enable_dpp_init(phba, lpfc_enable_dpp); - lpfc_enable_pbde_init(phba, lpfc_enable_pbde); if (phba->sli_rev != LPFC_SLI_REV4) { /* NVME only supported on SLI4 */ @@ -6558,6 +6548,8 @@ lpfc_get_cfgparam(struct lpfc_hba *phba) phba->cfg_auto_imax = 0; phba->initial_imax = phba->cfg_fcp_imax; + phba->cfg_enable_pbde = 0; + /* A value of 0 means use the number of CPUs found in the system */ if (phba->cfg_fcp_io_channel == 0) phba->cfg_fcp_io_channel = phba->sli4_hba.num_present_cpu;