From: Cédric Le Goater Date: Wed, 29 Apr 2020 07:51:22 +0000 (+0200) Subject: powerpc/xive: Do not expose a debugfs file when XIVE is disabled X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0755e85570a4615ca674ad6489d44d63916f1f3e;p=linux.git powerpc/xive: Do not expose a debugfs file when XIVE is disabled The XIVE interrupt mode can be disabled with the "xive=off" kernel parameter, in which case there is nothing to present to the user in the associated /sys/kernel/debug/powerpc/xive file. Fixes: 930914b7d528 ("powerpc/xive: Add a debugfs file to dump internal XIVE state") Signed-off-by: Cédric Le Goater Signed-off-by: Michael Ellerman Link: https://lore.kernel.org/r/20200429075122.1216388-4-clg@kaod.org --- diff --git a/arch/powerpc/sysdev/xive/common.c b/arch/powerpc/sysdev/xive/common.c index 3dbc94cb43808..f591be9f01f4e 100644 --- a/arch/powerpc/sysdev/xive/common.c +++ b/arch/powerpc/sysdev/xive/common.c @@ -1664,7 +1664,8 @@ DEFINE_SHOW_ATTRIBUTE(xive_core_debug); int xive_core_debug_init(void) { - debugfs_create_file("xive", 0400, powerpc_debugfs_root, - NULL, &xive_core_debug_fops); + if (xive_enabled()) + debugfs_create_file("xive", 0400, powerpc_debugfs_root, + NULL, &xive_core_debug_fops); return 0; }