From: Pavel Skripkin Date: Sun, 5 Sep 2021 20:42:18 +0000 (+0300) Subject: staging: r8188eu: remove useless check X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=07f32223c098cccfd549f996db76a5c578902e93;p=linux.git staging: r8188eu: remove useless check smatch says: usb_intf.c:326 rtw_hw_suspend() warn: variable dereferenced before check 'padapter' (see line 323) usb_intf.c:387 rtw_hw_resume() warn: variable dereferenced before check 'padapter' (see line 385) There is only one caller of rtw_hw_suspend() and it does not check padapter pointer, so let's just omit this check to make smatch happy. Signed-off-by: Pavel Skripkin Link: https://lore.kernel.org/r/20210905204218.19317-1-paskripkin@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/r8188eu/os_dep/usb_intf.c b/drivers/staging/r8188eu/os_dep/usb_intf.c index b7129e8b99245..56a4138a064fe 100644 --- a/drivers/staging/r8188eu/os_dep/usb_intf.c +++ b/drivers/staging/r8188eu/os_dep/usb_intf.c @@ -323,9 +323,6 @@ int rtw_hw_suspend(struct adapter *padapter) struct pwrctrl_priv *pwrpriv = &padapter->pwrctrlpriv; struct net_device *pnetdev = padapter->pnetdev; - - if (!padapter) - goto error_exit; if ((!padapter->bup) || (padapter->bDriverStopped) || (padapter->bSurpriseRemoved)) { DBG_88E("padapter->bup=%d bDriverStopped=%d bSurpriseRemoved = %d\n",