From: Tanmay Bhushan <007047221b@gmail.com> Date: Fri, 30 Dec 2022 14:18:58 +0000 (+0100) Subject: ext4: remove dead code in updating backup sb X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=08abd0466ec9113908e674d042ec2a36dfc2875c;p=linux.git ext4: remove dead code in updating backup sb ext4_update_backup_sb checks for err having some value after unlocking buffer. But err has not been updated till that point in any code which will lead execution of the code in question. Signed-off-by: Tanmay Bhushan <007047221b@gmail.com> Reviewed-by: Jan Kara Link: https://lore.kernel.org/r/20221230141858.3828-1-007047221b@gmail.com Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c index 8067ccda34e45..2e8c340363138 100644 --- a/fs/ext4/ioctl.c +++ b/fs/ext4/ioctl.c @@ -155,9 +155,6 @@ static int ext4_update_backup_sb(struct super_block *sb, set_buffer_uptodate(bh); unlock_buffer(bh); - if (err) - goto out_bh; - if (handle) { err = ext4_handle_dirty_metadata(handle, NULL, bh); if (err)