From: Markus Armbruster <armbru@redhat.com>
Date: Tue, 10 Feb 2015 14:15:43 +0000 (+0100)
Subject: monitor: Avoid qerror_report_err() outside QMP command handlers
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=091e38b7dc3255d780f0603b5b93c25078c39856;p=qemu.git

monitor: Avoid qerror_report_err() outside QMP command handlers

qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP.  It should not be used
elsewhere.  Replace by error_report_err() in HMP command handler
hmp_trace_event().

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---

diff --git a/monitor.c b/monitor.c
index ac2a4ab6e6..b1091888f6 100644
--- a/monitor.c
+++ b/monitor.c
@@ -889,8 +889,7 @@ static void do_trace_event_set_state(Monitor *mon, const QDict *qdict)
 
     qmp_trace_event_set_state(tp_name, new_state, true, true, &local_err);
     if (local_err) {
-        qerror_report_err(local_err);
-        error_free(local_err);
+        error_report_err(local_err);
     }
 }