From: Andy Shevchenko Date: Mon, 9 Jan 2023 13:27:19 +0000 (+0200) Subject: pinctrl: pinmux: Drop duplicate error message in pinmux_select() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=091e81b867796130a08be162ff8d9332492de26e;p=linux.git pinctrl: pinmux: Drop duplicate error message in pinmux_select() pinctrl_get_group_selector() prints an error message when group is not found in the list. No need to repeat this in the caller. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20230109132719.86009-1-andriy.shevchenko@linux.intel.com Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 6bd7ac37a0e0e..0213826326080 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -744,10 +744,8 @@ static ssize_t pinmux_select(struct file *file, const char __user *user_buf, } ret = pinctrl_get_group_selector(pctldev, gname); - if (ret < 0) { - dev_err(pctldev->dev, "failed to get group selector for %s", gname); + if (ret < 0) goto exit_free_buf; - } gsel = ret; ret = pmxops->set_mux(pctldev, fsel, gsel);