From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Date: Fri, 25 Jan 2019 07:40:32 +0000 (+0000)
Subject: i3c: fix missing detach if failed to retrieve i3c dev
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=093c61b6a0d5768f48442ec59d671496314cc47d;p=linux.git

i3c: fix missing detach if failed to retrieve i3c dev

If we failed to retrieve the i3c dev, we should detach the i3c dev
I.E i3c_master_detach_i3c_dev().

Signed-off-by: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
Signed-off-by: Boris Brezillon <bbrezillon@kernel.org>
---

diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index c39f89d2debaa..2dc628d4f1aee 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -1828,7 +1828,7 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master,
 
 	ret = i3c_master_retrieve_dev_info(newdev);
 	if (ret)
-		goto err_free_dev;
+		goto err_detach_dev;
 
 	olddev = i3c_master_search_i3c_dev_duplicate(newdev);
 	if (olddev) {