From: Kent Overstreet <kent.overstreet@linux.dev>
Date: Fri, 21 Apr 2023 07:33:45 +0000 (-0400)
Subject: bcachefs: Drop a redundant error message
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=09ebfa61130edaa990c0f1865fe2fa536d67c313;p=linux.git

bcachefs: Drop a redundant error message

When we're already read-only, we don't need to print out errors from
writing btree nodes.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
---

diff --git a/fs/bcachefs/btree_io.c b/fs/bcachefs/btree_io.c
index 0489d07a087f2..decbbaace1eef 100644
--- a/fs/bcachefs/btree_io.c
+++ b/fs/bcachefs/btree_io.c
@@ -1746,7 +1746,7 @@ static void btree_node_write_work(struct work_struct *work)
 	struct bch_fs *c	= wbio->wbio.c;
 	struct btree *b		= wbio->wbio.bio.bi_private;
 	struct bch_extent_ptr *ptr;
-	int ret;
+	int ret = 0;
 
 	btree_bounce_free(c,
 		wbio->data_bytes,
@@ -1776,7 +1776,8 @@ out:
 	return;
 err:
 	set_btree_node_noevict(b);
-	bch2_fs_fatal_error(c, "fatal error writing btree node");
+	if (!bch2_err_matches(ret, EROFS))
+		bch2_fs_fatal_error(c, "fatal error writing btree node");
 	goto out;
 }