From: Nishka Dasgupta Date: Sat, 6 Jul 2019 13:27:42 +0000 (+0530) Subject: drm/pl111: pl111_vexpress.c: Add of_node_put() before return X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0a869e8d82efa43aaa09ff3c145cc98b01cd8a7c;p=linux.git drm/pl111: pl111_vexpress.c: Add of_node_put() before return Each iteration of for_each_available_child_of_node puts the previous node, but in the case of a break from the middle of the loop there is no put, thus causing a memory leak. Hence add an of_node_put before the break. Issue found with Coccinelle. Signed-off-by: Nishka Dasgupta Signed-off-by: Eric Anholt Link: https://patchwork.freedesktop.org/patch/msgid/20190706132742.3250-1-nishkadg.linux@gmail.com --- diff --git a/drivers/gpu/drm/pl111/pl111_vexpress.c b/drivers/gpu/drm/pl111/pl111_vexpress.c index 38c938c9addaf..350570fe06b5f 100644 --- a/drivers/gpu/drm/pl111/pl111_vexpress.c +++ b/drivers/gpu/drm/pl111/pl111_vexpress.c @@ -51,6 +51,7 @@ int pl111_vexpress_clcd_init(struct device *dev, } if (of_device_is_compatible(child, "arm,hdlcd")) { has_coretile_hdlcd = true; + of_node_put(child); break; } }