From: Loïc Minier Date: Sat, 25 Sep 2010 19:52:30 +0000 (+0200) Subject: Avoid exit in trap as it breaks with some shells X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0ba8681eee36af77109505c34b5e29da52fa51ba;p=qemu.git Avoid exit in trap as it breaks with some shells Don't call exit in the trap handler as it causes the return code to be zero with some buggy shells (dash and pdksh at least) and is useless here anyway. Signed-off-by: Loïc Minier Signed-off-by: Blue Swirl --- diff --git a/configure b/configure index 6a21bf2a1f..02bda640cf 100755 --- a/configure +++ b/configure @@ -15,7 +15,9 @@ TMPC="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.c" TMPO="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.o" TMPE="${TMPDIR1}/qemu-conf-${RANDOM}-$$-${RANDOM}.exe" -trap "rm -f $TMPC $TMPO $TMPE ; exit" EXIT INT QUIT TERM +# NB: do not call "exit" in the trap handler; this is buggy with some shells; +# see <1285349658-3122-1-git-send-email-loic.minier@linaro.org> +trap "rm -f $TMPC $TMPO $TMPE" EXIT INT QUIT TERM compile_object() { $cc $QEMU_CFLAGS -c -o $TMPO $TMPC > /dev/null 2> /dev/null