From: Josef Bacik Date: Fri, 28 Jul 2017 14:42:24 +0000 (-0400) Subject: dm log writes: don't use all the cpu while waiting to log blocks X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0c79c62021d23f0b5c942cf59d43a7ce6c24cd1b;p=linux.git dm log writes: don't use all the cpu while waiting to log blocks The check to see if the logging kthread needs to go to sleep is wrong, it checks lc->pending_blocks, which will be non-0 if there are any blocks that are pending, whether they are ready to be logged or not. What we really want is to go to sleep until it's time to log blocks, so change this check so we do actually go to sleep in between flushes. Signed-off-by: Josef Bacik Signed-off-by: Mike Snitzer --- diff --git a/drivers/md/dm-log-writes.c b/drivers/md/dm-log-writes.c index a1da0eb58a93e..9aab510a17095 100644 --- a/drivers/md/dm-log-writes.c +++ b/drivers/md/dm-log-writes.c @@ -399,7 +399,7 @@ next: if (!try_to_freeze()) { set_current_state(TASK_INTERRUPTIBLE); if (!kthread_should_stop() && - !atomic_read(&lc->pending_blocks)) + list_empty(&lc->logging_blocks)) schedule(); __set_current_state(TASK_RUNNING); }