From: Yi Min Zhao Date: Wed, 10 Aug 2016 08:10:08 +0000 (+0800) Subject: s390x/pci: return directly if create zpci failed X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0d36d791927753599e9ca36e344f9fb272126e3d;p=qemu.git s390x/pci: return directly if create zpci failed In the case that zpci is automatically created, we did not return immediately on failure, which would lead to NULL pointer dereferencing. Let's fix it. Signed-off-by: Yi Min Zhao Signed-off-by: Cornelia Huck --- diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 9c1c04e590..5750f22fc3 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -649,6 +649,7 @@ static void s390_pcihost_hot_plug(HotplugHandler *hotplug_dev, pbdev = s390_pci_device_new(dev->id); if (!pbdev) { error_setg(errp, "create zpci device failed"); + return; } }