From: Thomas Huth Date: Wed, 16 Aug 2017 05:30:58 +0000 (+0200) Subject: s390x/ipl: The s390-ipl device is not hot-pluggable X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0d4fa4996fc5ee56ea7d072e272b8e69948460a5;p=qemu.git s390x/ipl: The s390-ipl device is not hot-pluggable The s390-ipl device can not be created by the user, since it is meant only to be instantiated once internally to load the ROMs and kernel. If the user tries to do a "device_add s390-ipl" via the monitor later, QEMU aborts with a "ROM images must be loaded at startup" error message. Signed-off-by: Thomas Huth Message-Id: <1502861458-30270-1-git-send-email-thuth@redhat.com> Reviewed-by: David Hildenbrand Signed-off-by: Cornelia Huck --- diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index cc360031ef..0d06fc12b6 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -442,6 +442,8 @@ static void s390_ipl_class_init(ObjectClass *klass, void *data) dc->reset = s390_ipl_reset; dc->vmsd = &vmstate_ipl; set_bit(DEVICE_CATEGORY_MISC, dc->categories); + /* Reason: Loads the ROMs and thus can only be used one time - internally */ + dc->user_creatable = false; } static const TypeInfo s390_ipl_info = {