From: Martin K. Petersen Date: Sat, 6 Apr 2024 01:07:23 +0000 (-0400) Subject: Merge patch series "scsi: ufs: Remove overzealous memory barriers" X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0e0a4da35284c85225e3b128912582ebc73256c8;p=linux.git Merge patch series "scsi: ufs: Remove overzealous memory barriers" Andrew Halaney says: Please review with care as I'm not all that confident in this subject. UFS has a lot of mb() variants used, most with comments saying "ensure this takes effect before continuing". mb()'s aren't really the way to guarantee that, a read back is the best method. Some of these though I think could go a step further and remove the mb() variant without a read back. As far as I can tell there's no real reason to ensure it takes effect in most cases (there's no delay() or anything afterwards, and eventually another readl()/writel() happens which is by definition ordered). Some of the patches in this series do that if I was confident it was safe (or a reviewer pointed out prior that they thought it was safe to do so). Thanks in advance for the help, Andrew Link: https://lore.kernel.org/r/20240329-ufs-reset-ensure-effect-before-delay-v5-0-181252004586@redhat.com Signed-off-by: Martin K. Petersen --- 0e0a4da35284c85225e3b128912582ebc73256c8