From: Stefan Wahren Date: Sun, 11 Apr 2021 18:11:36 +0000 (+0200) Subject: staging: vchiq_core: improve readability of request_poll X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0e345d97730678d526bed36947beda4eb15642de;p=linux.git staging: vchiq_core: improve readability of request_poll Storing the index for poll services in a local var will increase the readability of the second loop. Also we get the rid off the checkpatch issue about the line ending with a square bracket. Signed-off-by: Stefan Wahren Link: https://lore.kernel.org/r/1618164700-21150-7-git-send-email-stefan.wahren@i2se.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c index be0ea1e29569c..22989866ff70c 100644 --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.c @@ -537,6 +537,7 @@ request_poll(struct vchiq_state *state, struct vchiq_service *service, int poll_type) { u32 value; + int index; if (!service) goto skip_service; @@ -546,12 +547,11 @@ request_poll(struct vchiq_state *state, struct vchiq_service *service, } while (atomic_cmpxchg(&service->poll_flags, value, value | BIT(poll_type)) != value); + index = service->localport >> 5; do { - value = atomic_read(&state->poll_services[ - service->localport>>5]); - } while (atomic_cmpxchg( - &state->poll_services[service->localport>>5], value, - value | BIT(service->localport & 0x1f)) != value); + value = atomic_read(&state->poll_services[index]); + } while (atomic_cmpxchg(&state->poll_services[index], + value, value | BIT(service->localport & 0x1f)) != value); skip_service: state->poll_needed = 1;