From: Yan Zhao <yan.y.zhao@intel.com>
Date: Wed, 8 Apr 2020 07:12:34 +0000 (-0400)
Subject: vfio: avoid possible overflow in vfio_iommu_type1_pin_pages
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0ea971f8dcd6dee78a9a30ea70227cf305f11ff7;p=linux.git

vfio: avoid possible overflow in vfio_iommu_type1_pin_pages

add parentheses to avoid possible vaddr overflow.

Fixes: a54eb55045ae ("vfio iommu type1: Add support for mediated devices")
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
---

diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c
index aa501e826e703..fbc58284b3336 100644
--- a/drivers/vfio/vfio_iommu_type1.c
+++ b/drivers/vfio/vfio_iommu_type1.c
@@ -555,7 +555,7 @@ static int vfio_iommu_type1_pin_pages(void *iommu_data,
 			continue;
 		}
 
-		remote_vaddr = dma->vaddr + iova - dma->iova;
+		remote_vaddr = dma->vaddr + (iova - dma->iova);
 		ret = vfio_pin_page_external(dma, remote_vaddr, &phys_pfn[i],
 					     do_accounting);
 		if (ret)