From: Guenter Roeck <linux@roeck-us.net>
Date: Tue, 19 Jun 2012 05:30:51 +0000 (-0700)
Subject: hwmon: (ntc_thermistor) Ensure that data->name string is terminated
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0ef63e48f0247a9f9b9ffeef0f2641ac880728ab;p=linux.git

hwmon: (ntc_thermistor) Ensure that data->name string is terminated

Fix Coverity warning: Calling strncpy with a maximum size argument of 20 bytes
on destination array "data->name" of size 20 bytes might leave the destination
string unterminated.

Fix by replacing strncpy() with strlcpy() and by using sizeof() to determine
the maximum string length.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Acked-by: Jean Delvare <khali@linux-fr.org>
---

diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
index 6da9696e18273..74a6c58d02187 100644
--- a/drivers/hwmon/ntc_thermistor.c
+++ b/drivers/hwmon/ntc_thermistor.c
@@ -351,7 +351,7 @@ static int __devinit ntc_thermistor_probe(struct platform_device *pdev)
 
 	data->dev = &pdev->dev;
 	data->pdata = pdata;
-	strncpy(data->name, pdev->id_entry->name, PLATFORM_NAME_SIZE);
+	strlcpy(data->name, pdev->id_entry->name, sizeof(data->name));
 
 	switch (pdev->id_entry->driver_data) {
 	case TYPE_NCPXXWB473: