From: Luis Chamberlain Date: Fri, 17 Sep 2021 18:22:15 +0000 (-0700) Subject: firmware_loader: add a sanity check for firmware_request_builtin() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=0f8d7ccc2eab3e2ef39e49002e23e9677896715a;p=linux.git firmware_loader: add a sanity check for firmware_request_builtin() Right now firmware_request_builtin() is used internally only and so we have control over the callers. But if we want to expose that API more broadly we should ensure the firmware pointer is valid. This doesn't fix any known issue, it just prepares us to later expose this API to other users. Signed-off-by: Luis Chamberlain Link: https://lore.kernel.org/r/20210917182226.3532898-4-mcgrof@kernel.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index eb4085b92ad4c..d95b5fe5f700c 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c @@ -115,6 +115,9 @@ static bool firmware_request_builtin(struct firmware *fw, const char *name) { struct builtin_fw *b_fw; + if (!fw) + return false; + for (b_fw = __start_builtin_fw; b_fw != __end_builtin_fw; b_fw++) { if (strcmp(name, b_fw->name) == 0) { fw->size = b_fw->size;