From: Guido Kiener <guido.kiener@rohde-schwarz.com>
Date: Mon, 24 Sep 2018 23:30:29 +0000 (+0200)
Subject: usb: usbtmc: Fix memory leak in usbtmc_ioctl_request
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=100f2cdeadffb3e63121d1d59a60a9882258c415;p=linux.git

usb: usbtmc: Fix memory leak in usbtmc_ioctl_request

Kernel memory is allocated twice in new function
usbtmc_ioctl_request and creates a memory leak.
This fix removes the superfluous kmalloc().

Signed-off-by: Guido Kiener <guido.kiener@rohde-schwarz.com>
Fixes: 658f24f4523e ("usb: usbtmc: Add ioctl for generic requests on control")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c
index 0fcb81a1399b4..dfbcf418dad75 100644
--- a/drivers/usb/class/usbtmc.c
+++ b/drivers/usb/class/usbtmc.c
@@ -1895,10 +1895,6 @@ static int usbtmc_ioctl_request(struct usbtmc_device_data *data,
 	if (res)
 		return -EFAULT;
 
-	buffer = kmalloc(request.req.wLength, GFP_KERNEL);
-	if (!buffer)
-		return -ENOMEM;
-
 	if (request.req.wLength > USBTMC_BUFSIZE)
 		return -EMSGSIZE;