From: Heiner Kallweit Date: Fri, 6 Mar 2020 22:58:50 +0000 (+0100) Subject: r8169: remove now unneeded barrier in rtl_tx X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=101438729d8495c5d45eaffef61e55e00ec365a2;p=linux.git r8169: remove now unneeded barrier in rtl_tx Until ae84bc187337 ("r8169: don't use bit LastFrag in tx descriptor after send") we used to access another bit in the descriptor, therefore it seems the barrier was needed. Since this commit DescOwn is the only bit we're interested in, so the barrier isn't needed any longer. Signed-off-by: Heiner Kallweit Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index 8a707d67c8d8c..181b35b78c61d 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4397,12 +4397,6 @@ static void rtl_tx(struct net_device *dev, struct rtl8169_private *tp, if (status & DescOwn) break; - /* This barrier is needed to keep us from reading - * any other fields out of the Tx descriptor until - * we know the status of DescOwn - */ - dma_rmb(); - rtl8169_unmap_tx_skb(tp, entry); if (skb) {