From: YueHaibing Date: Wed, 12 Jun 2019 03:18:25 +0000 (+0800) Subject: ipmi: ipmb: Fix build error while CONFIG_I2C is set to m X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=102308f557bca8e539a800614b0e274945a81cdf;p=linux.git ipmi: ipmb: Fix build error while CONFIG_I2C is set to m If CONFIG_I2C is m and CONFIG_I2C_SLAVE is y, building with CONFIG_IPMB_DEVICE_INTERFACE setting to y will fail: drivers/char/ipmi/ipmb_dev_int.o: In function `ipmb_remove': ipmb_dev_int.c: undefined reference to `i2c_slave_unregister' drivers/char/ipmi/ipmb_dev_int.o: In function `ipmb_write': ipmb_dev_int.c: undefined reference to `i2c_smbus_write_block_data' drivers/char/ipmi/ipmb_dev_int.o: In function `ipmb_probe': ipmb_dev_int.c: undefined reference to `i2c_slave_register' drivers/char/ipmi/ipmb_dev_int.o: In function `ipmb_driver_init': ipmb_dev_int.c: undefined reference to `i2c_register_driver' drivers/char/ipmi/ipmb_dev_int.o: In function `ipmb_driver_exit': ipmb_dev_int.c: undefined reference to `i2c_del_driver' Add I2C Kconfig dependency to fix this. Reported-by: Hulk Robot Fixes: 51bd6f291583 ("Add support for IPMB driver") Signed-off-by: YueHaibing Message-Id: <20190612031825.24732-1-yuehaibing@huawei.com> Signed-off-by: Corey Minyard --- diff --git a/drivers/char/ipmi/Kconfig b/drivers/char/ipmi/Kconfig index a9cfe4c05e640..e36db1b085d86 100644 --- a/drivers/char/ipmi/Kconfig +++ b/drivers/char/ipmi/Kconfig @@ -134,6 +134,7 @@ config ASPEED_BT_IPMI_BMC config IPMB_DEVICE_INTERFACE tristate 'IPMB Interface handler' + depends on I2C depends on I2C_SLAVE help Provides a driver for a device (Satellite MC) to