From: Zheng Bin Date: Wed, 11 May 2022 03:29:37 +0000 (+0800) Subject: accessiblity: speakup: Add missing misc_deregister in softsynth_probe X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=106101303eda8f93c65158e5d72b2cc6088ed034;p=linux.git accessiblity: speakup: Add missing misc_deregister in softsynth_probe softsynth_probe misses a call misc_deregister() in an error path, this patch fixes that. Signed-off-by: Zheng Bin Link: https://lore.kernel.org/r/20220511032937.2736738-1-zhengbin13@huawei.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/accessibility/speakup/speakup_soft.c b/drivers/accessibility/speakup/speakup_soft.c index 1ced2721513e1..99f1d4ac426a4 100644 --- a/drivers/accessibility/speakup/speakup_soft.c +++ b/drivers/accessibility/speakup/speakup_soft.c @@ -397,6 +397,7 @@ static int softsynth_probe(struct spk_synth *synth) synthu_device.name = "softsynthu"; synthu_device.fops = &softsynthu_fops; if (misc_register(&synthu_device)) { + misc_deregister(&synth_device); pr_warn("Couldn't initialize miscdevice /dev/softsynthu.\n"); return -ENODEV; }