From: Gustavo A. R. Silva Date: Wed, 4 Jul 2018 14:22:55 +0000 (-0500) Subject: drm/pl111: Use 64-bit arithmetic instead of 32-bit X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=108019a7e6a34df91246365066bea7cf6faf6b02;p=linux.git drm/pl111: Use 64-bit arithmetic instead of 32-bit Add suffix ULL to constant 1000 in order to give the compiler complete information about the proper arithmetic to use. Notice that such constant is used in a context that expects an expression of type u64 (64 bits, unsigned) and the following expression is currently being evaluated using 32-bit arithmetic: mode->clock * 1000 Addresses-Coverity-ID: 1466139 ("Unintentional integer overflow") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Eric Anholt Link: https://patchwork.freedesktop.org/patch/msgid/20180704142255.GA8614@embeddedor.com --- diff --git a/drivers/gpu/drm/pl111/pl111_display.c b/drivers/gpu/drm/pl111/pl111_display.c index a432eb7ad4454..754f6b25f2652 100644 --- a/drivers/gpu/drm/pl111/pl111_display.c +++ b/drivers/gpu/drm/pl111/pl111_display.c @@ -63,7 +63,7 @@ pl111_mode_valid(struct drm_crtc *crtc, * We use the pixelclock to also account for interlaced modes, the * resulting bandwidth is in bytes per second. */ - bw = mode->clock * 1000; /* In Hz */ + bw = mode->clock * 1000ULL; /* In Hz */ bw = bw * mode->hdisplay * mode->vdisplay * cpp; bw = div_u64(bw, mode->htotal * mode->vtotal);