From: Andreas Färber Date: Thu, 2 May 2013 09:22:05 +0000 (+0200) Subject: cpus: Fix pausing TCG CPUs while in vCPU thread X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1085819368e8693f08307e72f0082d759f67ef03;p=qemu.git cpus: Fix pausing TCG CPUs while in vCPU thread Due to a preceding while loop, no CPU would've been put into stopped state. Reinitialize the variable. This fixes commit d798e97456658ea7605303b7c69b04ec7df95c10 (Allow to use pause_all_vcpus from VCPU context) for non-KVM case. While at it, change a 0 to false, amending commit 4fdeee7cd4c8f90ef765537b9346a195d9483ab5 (cpu: Move stop field to CPUState). Reviewed-by: Jan Kiszka Signed-off-by: Andreas Färber --- diff --git a/cpus.c b/cpus.c index a2d92c7a88..c232265cd2 100644 --- a/cpus.c +++ b/cpus.c @@ -974,9 +974,10 @@ void pause_all_vcpus(void) if (qemu_in_vcpu_thread()) { cpu_stop_current(); if (!kvm_enabled()) { + penv = first_cpu; while (penv) { CPUState *pcpu = ENV_GET_CPU(penv); - pcpu->stop = 0; + pcpu->stop = false; pcpu->stopped = true; penv = penv->next_cpu; }