From: Christoph Hellwig Date: Tue, 28 Apr 2020 08:52:03 +0000 (+0200) Subject: block: remove the bd_openers checks in blk_drop_partitions X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=10c70d95c0f2f9a6f52d0e33243d2877370cef51;p=linux.git block: remove the bd_openers checks in blk_drop_partitions When replacing the bd_super check with a bd_openers I followed a logical conclusion, which turns out to be utterly wrong. When a block device has bd_super sets it has a mount file system on it (although not every mounted file system sets bd_super), but that also implies it doesn't even have partitions to start with. So instead of trying to come up with a logical check for all openers, just remove the check entirely. Fixes: d3ef5536274f ("block: fix busy device checking in blk_drop_partitions") Fixes: cb6b771b05c3 ("block: fix busy device checking in blk_drop_partitions again") Reported-by: Michal Koutný Reported-by: Yang Xu Signed-off-by: Christoph Hellwig Signed-off-by: Jens Axboe --- diff --git a/block/partitions/core.c b/block/partitions/core.c index bc1ded1331b14..9ef48a8cff867 100644 --- a/block/partitions/core.c +++ b/block/partitions/core.c @@ -496,7 +496,7 @@ int blk_drop_partitions(struct gendisk *disk, struct block_device *bdev) if (!disk_part_scan_enabled(disk)) return 0; - if (bdev->bd_part_count || bdev->bd_openers > 1) + if (bdev->bd_part_count) return -EBUSY; res = invalidate_partition(disk, 0); if (res)