From: Martin Kaiser Date: Sat, 9 Apr 2022 16:32:09 +0000 (+0200) Subject: staging: r8188eu: improve timeout handling in LPS_RF_ON_check X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=11788aac9228875cac0a6b1a303521fe47115d24;p=linux.git staging: r8188eu: improve timeout handling in LPS_RF_ON_check Use the standard kernel functions to define and check the timeout in LPS_RF_ON_check. Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20220409163212.241122-8-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/r8188eu/core/rtw_pwrctrl.c b/drivers/staging/r8188eu/core/rtw_pwrctrl.c index bd03b229a7973..8c2e98361e477 100644 --- a/drivers/staging/r8188eu/core/rtw_pwrctrl.c +++ b/drivers/staging/r8188eu/core/rtw_pwrctrl.c @@ -250,10 +250,9 @@ static bool lps_rf_on(struct adapter *adapter) */ static s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) { - u32 start_time; + unsigned long timeout = jiffies + msecs_to_jiffies(delay_ms); s32 err = 0; - start_time = jiffies; while (1) { if (lps_rf_on(padapter)) break; @@ -263,7 +262,7 @@ static s32 LPS_RF_ON_check(struct adapter *padapter, u32 delay_ms) break; } - if (rtw_get_passing_time_ms(start_time) > delay_ms) { + if (time_after(jiffies, timeout)) { err = -1; break; }