From: Gustavo A. R. Silva Date: Thu, 19 Apr 2018 13:24:29 +0000 (-0500) Subject: ipmi_ssif: Fix uninitialized variable issue X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1211229399b3f9b8b0e337c898efb09695f71c91;p=linux.git ipmi_ssif: Fix uninitialized variable issue Currently, function ssif_remove returns _rv_, which is a variable that is never initialized. Fix this by removing variable _rv_ and return 0 instead. Addresses-Coverity-ID: 1467999 ("Uninitialized scalar variable") Fixes: 6a0d23ed338e ("ipmi: ipmi_unregister_smi() cannot fail, have it return void") Signed-off-by: Gustavo A. R. Silva Signed-off-by: Corey Minyard --- diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c index ecabfe27c8288..37f9ae2de6a4e 100644 --- a/drivers/char/ipmi/ipmi_ssif.c +++ b/drivers/char/ipmi/ipmi_ssif.c @@ -1227,7 +1227,6 @@ static int ssif_remove(struct i2c_client *client) struct ssif_info *ssif_info = i2c_get_clientdata(client); struct ipmi_smi *intf; struct ssif_addr_info *addr_info; - int rv; if (!ssif_info) return 0; @@ -1247,7 +1246,7 @@ static int ssif_remove(struct i2c_client *client) } } - return rv; + return 0; } static int do_cmd(struct i2c_client *client, int len, unsigned char *msg,