From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Date: Thu, 28 Mar 2019 18:36:14 +0000 (-0400)
Subject: media: dvbdev: remove double-unlock
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=122d0e8dd050cc5dc3fb9e9b5f2dee3c5276ce35;p=linux.git

media: dvbdev: remove double-unlock

As warned by smatch:
	drivers/media/dvb-core/dvbdev.c: drivers/media/dvb-core/dvbdev.c:529 dvb_register_device() error: double unlock 'sem:&minor_rwsem'

Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---

diff --git a/drivers/media/dvb-core/dvbdev.c b/drivers/media/dvb-core/dvbdev.c
index 4a5834a1c3b72..a3393cd4e584f 100644
--- a/drivers/media/dvb-core/dvbdev.c
+++ b/drivers/media/dvb-core/dvbdev.c
@@ -526,7 +526,6 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev,
 		dvb_media_device_free(dvbdev);
 		kfree(dvbdevfops);
 		kfree(dvbdev);
-		up_write(&minor_rwsem);
 		mutex_unlock(&dvbdev_register_lock);
 		return ret;
 	}