From: Jakub Kicinski <jakub.kicinski@netronome.com>
Date: Thu, 24 May 2018 07:41:19 +0000 (-0700)
Subject: bpfilter: don't pass O_CREAT when opening console for debug
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=13405468f49d4b6e014fdf376f46393f9590769d;p=linux.git

bpfilter: don't pass O_CREAT when opening console for debug

Passing O_CREAT (00000100) to open means we should also pass file
mode as the third parameter.  Creating /dev/console as a regular
file may not be helpful anyway, so simply drop the flag when
opening debug_fd.

Fixes: d2ba09c17a06 ("net: add skeleton of bpfilter kernel module")
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Acked-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/bpfilter/main.c b/net/bpfilter/main.c
index 81bbc1684896e..1317f108df8ae 100644
--- a/net/bpfilter/main.c
+++ b/net/bpfilter/main.c
@@ -55,7 +55,7 @@ static void loop(void)
 
 int main(void)
 {
-	debug_fd = open("/dev/console", 00000002 | 00000100);
+	debug_fd = open("/dev/console", 00000002);
 	dprintf(debug_fd, "Started bpfilter\n");
 	loop();
 	close(debug_fd);