From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Date: Sun, 18 Feb 2018 21:02:42 +0000 (+0100) Subject: serial: imx: drop if that always evaluates to true X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=135ccb0129952966715074398f422c1517f2e7ad;p=linux.git serial: imx: drop if that always evaluates to true The check sts & USR1_DTRD was just evaluated to true two lines above. So this change doesn't have any effect on the semantic of the driver. Fixes: 27e16501052e ("serial: imx: implement DSR irq handling for DTE mode") Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Shawn Guo <shawnguo@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> --- diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c index ace96283bdb8f..6c926f7026558 100644 --- a/drivers/tty/serial/imx.c +++ b/drivers/tty/serial/imx.c @@ -781,8 +781,7 @@ static irqreturn_t imx_int(int irq, void *dev_id) if (sts & USR1_DTRD) { unsigned long flags; - if (sts & USR1_DTRD) - writel(USR1_DTRD, sport->port.membase + USR1); + writel(USR1_DTRD, sport->port.membase + USR1); spin_lock_irqsave(&sport->port.lock, flags); imx_mctrl_check(sport);