From: Eric Dumazet <edumazet@google.com>
Date: Thu, 2 May 2024 11:37:47 +0000 (+0000)
Subject: rtnetlink: change rtnl_stats_dump() return value
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=136c2a9a2a8760d8dae83ae7c882c50be02bdb63;p=linux.git

rtnetlink: change rtnl_stats_dump() return value

By returning 0 (or an error) instead of skb->len,
we allow NLMSG_DONE to be appended to the current
skb at the end of a dump, saving a couple of recvmsg()
system calls.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20240502113748.1622637-2-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 283e42f48af68..88980c8bcf334 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -6024,7 +6024,7 @@ out:
 	cb->args[1] = idx;
 	cb->args[0] = h;
 
-	return skb->len;
+	return err;
 }
 
 void rtnl_offload_xstats_notify(struct net_device *dev)