From: Peter Maydell <peter.maydell@linaro.org>
Date: Thu, 16 Feb 2012 09:56:10 +0000 (+0000)
Subject: hw/pl031: Actually raise interrupt on timer expiry
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=13a16f1d91fc7a46b65b22a33f6ffea1b826a097;p=qemu.git

hw/pl031: Actually raise interrupt on timer expiry

Fix a typo in pl031_interrupt() which meant we were setting a bit
in the interrupt mask rather than the interrupt status register
and thus not actually raising an interrupt. This fix allows the
rtctest program from the kernel's Documentation/rtc.txt to pass
rather than hanging.

Reported-by: Daniel Forsgren <daniel.forsgren@enea.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Acked-by: Andreas Färber <afaerber@suse.de>
---

diff --git a/hw/pl031.c b/hw/pl031.c
index 05b5b11e1a..69abc4f345 100644
--- a/hw/pl031.c
+++ b/hw/pl031.c
@@ -76,7 +76,7 @@ static void pl031_interrupt(void * opaque)
 {
     pl031_state *s = (pl031_state *)opaque;
 
-    s->im = 1;
+    s->is = 1;
     DPRINTF("Alarm raised\n");
     pl031_update(s);
 }