From: Oleg Nesterov <oleg@redhat.com>
Date: Sat, 9 Sep 2023 17:26:29 +0000 (+0200)
Subject: getrusage: use __for_each_thread()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=13b7bc60b5353371460a203df6c38ccd38ad7a3a;p=linux.git

getrusage: use __for_each_thread()

do/while_each_thread should be avoided when possible.

Plus this change allows to avoid lock_task_sighand(), we can use rcu
and/or sig->stats_lock instead.

Link: https://lkml.kernel.org/r/20230909172629.GA20454@redhat.com
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

diff --git a/kernel/sys.c b/kernel/sys.c
index 097cbea62a72e..67436d465be45 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1830,10 +1830,8 @@ void getrusage(struct task_struct *p, int who, struct rusage *r)
 		r->ru_oublock += sig->oublock;
 		if (maxrss < sig->maxrss)
 			maxrss = sig->maxrss;
-		t = p;
-		do {
+		__for_each_thread(sig, t)
 			accumulate_thread_rusage(t, r);
-		} while_each_thread(p, t);
 		break;
 
 	default: