From: Uwe Kleine-König Date: Sun, 19 Mar 2023 10:06:19 +0000 (+0100) Subject: of: unittest: Drop if blocks with always false condition X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=13cd9ac670df5e052d3a31ae21bb1787202870dd;p=linux.git of: unittest: Drop if blocks with always false condition unittest_gpio_remove() is only called after unittest_gpio_probe() completed successfully. In this case driver data was set to a non-NULL value and so platform_get_drvdata() never returns NULL. Also note that the compiler might optimize away this check anyhow as devptr was already dereferenced for the dev_dbg call above. Drop this if block. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20230319100620.295849-3-u.kleine-koenig@pengutronix.de Signed-off-by: Rob Herring --- diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 2504092e83026..0b0b966133b75 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1633,9 +1633,6 @@ static int unittest_gpio_remove(struct platform_device *pdev) dev_dbg(dev, "%s for node @%pfw\n", __func__, devptr->chip.fwnode); - if (!devptr) - return -EINVAL; - if (devptr->chip.base != -1) gpiochip_remove(&devptr->chip);