From: Zhengchao Shao <shaozhengchao@huawei.com>
Date: Thu, 17 Nov 2022 06:45:00 +0000 (+0800)
Subject: wifi: mac80211: fix memory leak in ieee80211_if_add()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=13e5afd3d773c6fc6ca2b89027befaaaa1ea7293;p=linux.git

wifi: mac80211: fix memory leak in ieee80211_if_add()

When register_netdevice() failed in ieee80211_if_add(), ndev->tstats
isn't released. Fix it.

Fixes: 5a490510ba5f ("mac80211: use per-CPU TX/RX statistics")
Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
Link: https://lore.kernel.org/r/20221117064500.319983-1-shaozhengchao@huawei.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---

diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 7c4ce716c9394..a5782927a93b0 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -2195,6 +2195,7 @@ int ieee80211_if_add(struct ieee80211_local *local, const char *name,
 
 		ret = cfg80211_register_netdevice(ndev);
 		if (ret) {
+			ieee80211_if_free(ndev);
 			free_netdev(ndev);
 			return ret;
 		}