From: Esben Haabendal <esben@geanix.com>
Date: Tue, 6 Dec 2022 08:46:37 +0000 (+0100)
Subject: gpioset: fix memory leak in interactive mode
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=141b91774935fd8fc234b091f3e6daf940782698;p=qemu-gpiodev%2Flibgpiod.git

gpioset: fix memory leak in interactive mode

Even when readline() returns an empty buffer, we still need to free() it to
avoid leaking memory.

Signed-off-by: Esben Haabendal <esben@geanix.com>
[Kent: suggested a shorter version]
Co-developed-by: Kent Gibson <warthog618@gmail.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---

diff --git a/tools/gpioset.c b/tools/gpioset.c
index 698dba3..374fe72 100644
--- a/tools/gpioset.c
+++ b/tools/gpioset.c
@@ -768,8 +768,10 @@ static void interact(struct gpiod_line_request **requests,
 		fflush(stdout);
 
 		line = readline(PROMPT);
-		if (!line || line[0] == '\0')
+		if (!line || line[0] == '\0') {
+			free(line);
 			continue;
+		}
 
 		for (i = strlen(line) - 1; (i > 0) && isspace(line[i]); i--)
 			line[i] = '\0';