From: John Snow Date: Thu, 27 May 2021 21:16:47 +0000 (-0400) Subject: python/machine: use subprocess.run instead of subprocess.Popen X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=14b41797d5eb20fb9c6d0a1fe809e8422938f230;p=qemu.git python/machine: use subprocess.run instead of subprocess.Popen use run() instead of Popen() -- to assert to pylint that we are not forgetting to close a long-running program. Signed-off-by: John Snow Reviewed-by: Cleber Rosa Tested-by: Cleber Rosa Message-id: 20210527211715.394144-4-jsnow@redhat.com Message-id: 20210517184808.3562549-4-jsnow@redhat.com Signed-off-by: John Snow --- diff --git a/python/qemu/machine.py b/python/qemu/machine.py index 5b87e9ce02..04e005f381 100644 --- a/python/qemu/machine.py +++ b/python/qemu/machine.py @@ -223,13 +223,16 @@ class QEMUMachine: assert fd is not None fd_param.append(str(fd)) - proc = subprocess.Popen( - fd_param, stdin=subprocess.DEVNULL, stdout=subprocess.PIPE, - stderr=subprocess.STDOUT, close_fds=False + proc = subprocess.run( + fd_param, + stdin=subprocess.DEVNULL, + stdout=subprocess.PIPE, + stderr=subprocess.STDOUT, + check=False, + close_fds=False, ) - output = proc.communicate()[0] - if output: - LOG.debug(output) + if proc.stdout: + LOG.debug(proc.stdout) return proc.returncode