From: Benjamin Coddington <bcodding@redhat.com>
Date: Tue, 5 Dec 2023 15:05:01 +0000 (-0500)
Subject: blocklayoutdriver: Fix reference leak of pnfs_device_node
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1530827b90025cdf80c9b0d07a166d045a0a7b81;p=linux.git

blocklayoutdriver: Fix reference leak of pnfs_device_node

The error path for blocklayout's device lookup is missing a reference drop
for the case where a lookup finds the device, but the device is marked with
NFS_DEVICEID_UNAVAILABLE.

Fixes: b3dce6a2f060 ("pnfs/blocklayout: handle transient devices")
Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
---

diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c
index 943aeea1eb160..1d1d7abc32051 100644
--- a/fs/nfs/blocklayout/blocklayout.c
+++ b/fs/nfs/blocklayout/blocklayout.c
@@ -580,6 +580,8 @@ retry:
 		nfs4_delete_deviceid(node->ld, node->nfs_client, id);
 		goto retry;
 	}
+
+	nfs4_put_deviceid_node(node);
 	return ERR_PTR(-ENODEV);
 }