From: Peter Zijlstra Date: Tue, 8 Jun 2021 17:54:15 +0000 (+0200) Subject: irq_work: Make irq_work_queue() NMI-safe again X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=156172a13ff0626d8e23276e741c7e2cb2f3b572;p=linux.git irq_work: Make irq_work_queue() NMI-safe again Someone carelessly put NMI unsafe code in irq_work_queue(), breaking just about every single user. Also, someone has a terrible comment style. Fixes: e2b5bcf9f5ba ("irq_work: record irq_work_queue() call stack") Reported-by: Alexander Shishkin Signed-off-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/YL+uBq8LzXXZsYVf@hirez.programming.kicks-ass.net --- diff --git a/kernel/irq_work.c b/kernel/irq_work.c index 23a7a0ba1388a..db8c248ebc8c8 100644 --- a/kernel/irq_work.c +++ b/kernel/irq_work.c @@ -70,9 +70,6 @@ bool irq_work_queue(struct irq_work *work) if (!irq_work_claim(work)) return false; - /*record irq_work call stack in order to print it in KASAN reports*/ - kasan_record_aux_stack(work); - /* Queue the entry and raise the IPI if needed. */ preempt_disable(); __irq_work_queue_local(work);