From: Eric Blake Date: Tue, 27 Oct 2020 05:05:46 +0000 (-0500) Subject: block: Simplify QAPI_LIST_ADD X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=159f8442382cff6ef6d858dbf02f03f0cc95b4a7;p=qemu.git block: Simplify QAPI_LIST_ADD There is no need to rely on the verbosity of the gcc/clang compiler extension of g_new(typeof(X), 1) when we can instead use the standard g_malloc(sizeof(X)). In general, we like g_new over g_malloc for returning type X rather than void* to let the compiler catch more potential typing mistakes, but in this particular macro, our other use of typeof on the same line already ensures we are getting correct results. Suggested-by: Markus Armbruster Signed-off-by: Eric Blake Message-Id: <20201027050556.269064-2-eblake@redhat.com> Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Markus Armbruster --- diff --git a/block.c b/block.c index ee5b28a979..dd551d7ea9 100644 --- a/block.c +++ b/block.c @@ -5240,7 +5240,7 @@ BlockDeviceInfoList *bdrv_named_nodes_list(bool flat, } #define QAPI_LIST_ADD(list, element) do { \ - typeof(list) _tmp = g_new(typeof(*(list)), 1); \ + typeof(list) _tmp = g_malloc(sizeof(*(list))); \ _tmp->value = (element); \ _tmp->next = (list); \ (list) = _tmp; \