From: ye xingchen <ye.xingchen@zte.com.cn>
Date: Mon, 5 Dec 2022 11:18:56 +0000 (+0800)
Subject: net: ethernet: use sysfs_emit() to instead of scnprintf()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=16dc16d9f058dce7031ee8b850f10622b8b5fb14;p=linux.git

net: ethernet: use sysfs_emit() to instead of scnprintf()

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Link: https://lore.kernel.org/r/202212051918564721658@zte.com.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index e02daa74e8334..2edc8b796a4e7 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -398,7 +398,7 @@ EXPORT_SYMBOL(alloc_etherdev_mqs);
 
 ssize_t sysfs_format_mac(char *buf, const unsigned char *addr, int len)
 {
-	return scnprintf(buf, PAGE_SIZE, "%*phC\n", len, addr);
+	return sysfs_emit(buf, "%*phC\n", len, addr);
 }
 EXPORT_SYMBOL(sysfs_format_mac);