From: Heiko Carstens Date: Sun, 2 Apr 2023 18:55:21 +0000 (+0200) Subject: s390/module: create module allocations without exec permissions X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=1707c1165283a9634717971f17692535c21ab0eb;p=linux.git s390/module: create module allocations without exec permissions This is the s390 variant of commit 7dfac3c5f40e ("arm64: module: create module allocations without exec permissions"): "The core code manages the executable permissions of code regions of modules explicitly. It is no longer necessary to create the module vmalloc regions with RWX permissions. So create them with RW- permissions instead, which is preferred from a security perspective." Reviewed-by: Alexander Gordeev Signed-off-by: Heiko Carstens Signed-off-by: Vasily Gorbik --- diff --git a/arch/s390/kernel/module.c b/arch/s390/kernel/module.c index 57c13e30e66d3..07a13546980d9 100644 --- a/arch/s390/kernel/module.c +++ b/arch/s390/kernel/module.c @@ -63,7 +63,7 @@ void *module_alloc(unsigned long size) return NULL; p = __vmalloc_node_range(size, MODULE_ALIGN, MODULES_VADDR + get_module_load_offset(), MODULES_END, - gfp_mask, PAGE_KERNEL_EXEC, VM_DEFER_KMEMLEAK, NUMA_NO_NODE, + gfp_mask, PAGE_KERNEL, VM_DEFER_KMEMLEAK, NUMA_NO_NODE, __builtin_return_address(0)); if (p && (kasan_alloc_module_shadow(p, size, gfp_mask) < 0)) { vfree(p);