From: Jonathan Cormier Date: Thu, 26 Jan 2023 22:32:25 +0000 (-0500) Subject: hwmon: (ltc2945) Handle error case in ltc2945_value_store X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=178b01eccfb0b8149682f61388400bd3d903dddc;p=linux.git hwmon: (ltc2945) Handle error case in ltc2945_value_store ltc2945_val_to_reg errors were not being handled which would have resulted in register being set to 0 (clamped) instead of being left alone. Fixes: 6700ce035f83 ("hwmon: Driver for Linear Technologies LTC2945") Signed-off-by: Jonathan Cormier Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/ltc2945.c b/drivers/hwmon/ltc2945.c index 9af3e3821152b..ac15298a65583 100644 --- a/drivers/hwmon/ltc2945.c +++ b/drivers/hwmon/ltc2945.c @@ -254,6 +254,8 @@ static ssize_t ltc2945_value_store(struct device *dev, /* convert to register value, then clamp and write result */ regval = ltc2945_val_to_reg(dev, reg, val); + if (regval < 0) + return regval; if (is_power_reg(reg)) { regval = clamp_val(regval, 0, 0xffffff); regbuf[0] = regval >> 16;