From: Corey Minyard <cminyard@mvista.com>
Date: Thu, 30 Sep 2021 21:12:55 +0000 (-0500)
Subject: ipmi:devintf: Return a proper error when recv buffer too small
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=17a4262799fa7449e8fe06fe6d930ab7f5f32528;p=linux.git

ipmi:devintf: Return a proper error when recv buffer too small

The right error message wasn't being set in one location, and it would
return success on a failure.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
---

diff --git a/drivers/char/ipmi/ipmi_devintf.c b/drivers/char/ipmi/ipmi_devintf.c
index 3dd1d5abb298a..d160fa4c73fec 100644
--- a/drivers/char/ipmi/ipmi_devintf.c
+++ b/drivers/char/ipmi/ipmi_devintf.c
@@ -247,11 +247,13 @@ static int handle_recv(struct ipmi_file_private *priv,
 
 	if (msg->msg.data_len > 0) {
 		if (rsp->msg.data_len < msg->msg.data_len) {
-			rv2 = -EMSGSIZE;
-			if (trunc)
+			if (trunc) {
+				rv2 = -EMSGSIZE;
 				msg->msg.data_len = rsp->msg.data_len;
-			else
+			} else {
+				rv = -EMSGSIZE;
 				goto recv_putback_on_err;
+			}
 		}
 
 		if (copy_to_user(rsp->msg.data,