From: Zou Wei <zou_wei@huawei.com>
Date: Tue, 8 Jun 2021 12:35:32 +0000 (+0800)
Subject: PNP: pnpbios: Use list_for_each_entry() instead of list_for_each()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=17aa26c96fb240de92db90ec1bfd616f28b6dc16;p=linux.git

PNP: pnpbios: Use list_for_each_entry() instead of list_for_each()

Use list_for_each_entry() instead of list_for_each() where
applicable.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zou Wei <zou_wei@huawei.com>
[ rjw: Subject and changelog rewrite ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---

diff --git a/drivers/pnp/pnpbios/core.c b/drivers/pnp/pnpbios/core.c
index 9b760e73ee8f2..669ef4700c1ac 100644
--- a/drivers/pnp/pnpbios/core.c
+++ b/drivers/pnp/pnpbios/core.c
@@ -298,14 +298,12 @@ struct pnp_protocol pnpbios_protocol = {
 
 static int __init insert_device(struct pnp_bios_node *node)
 {
-	struct list_head *pos;
 	struct pnp_dev *dev;
 	char id[8];
 	int error;
 
 	/* check if the device is already added */
-	list_for_each(pos, &pnpbios_protocol.devices) {
-		dev = list_entry(pos, struct pnp_dev, protocol_list);
+	list_for_each_entry(dev, &pnpbios_protocol.devices, protocol_list) {
 		if (dev->number == node->handle)
 			return -EEXIST;
 	}