From: kernel test robot Date: Tue, 17 Aug 2021 05:13:14 +0000 (-0700) Subject: scsi: qla2xxx: edif: Fix returnvar.cocci warnings X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=17f3df8fd718fb229ae3453ae59b3f2349464d06;p=linux.git scsi: qla2xxx: edif: Fix returnvar.cocci warnings drivers/scsi/qla2xxx/qla_edif.c:213:25-29: Unneeded variable: "rval". Return "0" on line 264 Remove unneeded variable used to store return value. Generated by: scripts/coccinelle/misc/returnvar.cocci Link: https://lore.kernel.org/r/20210817051315.2477-12-njavali@marvell.com Fixes: 7ebb336e45ef ("scsi: qla2xxx: edif: Add start + stop bsgs") Reported-by: kernel test robot Signed-off-by: kernel test robot Signed-off-by: Nilesh Javali Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/qla2xxx/qla_edif.c b/drivers/scsi/qla2xxx/qla_edif.c index dc10874a0c99b..ad746c62f0d44 100644 --- a/drivers/scsi/qla2xxx/qla_edif.c +++ b/drivers/scsi/qla2xxx/qla_edif.c @@ -628,7 +628,6 @@ qla_edif_app_start(scsi_qla_host_t *vha, struct bsg_job *bsg_job) static int qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job) { - int32_t rval = 0; struct app_stop appstop; struct fc_bsg_reply *bsg_reply = bsg_job->reply; struct fc_port *fcport, *tf; @@ -679,7 +678,7 @@ qla_edif_app_stop(scsi_qla_host_t *vha, struct bsg_job *bsg_job) /* no return interface to app - it assumes we cleaned up ok */ - return rval; + return 0; } static int