From: Wang Shilong <wshilong@ddn.com>
Date: Wed, 3 Oct 2018 16:19:21 +0000 (-0400)
Subject: ext4: propagate error from dquot_initialize() in EXT4_IOC_FSSETXATTR
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=182a79e0c17147d2c2d3990a9a7b6b58a1561c7a;p=linux.git

ext4: propagate error from dquot_initialize() in EXT4_IOC_FSSETXATTR

We return most failure of dquota_initialize() except
inode evict, this could make a bit sense, for example
we allow file removal even quota files are broken?

But it dosen't make sense to allow setting project
if quota files etc are broken.

Signed-off-by: Wang Shilong <wshilong@ddn.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
---

diff --git a/fs/ext4/ioctl.c b/fs/ext4/ioctl.c
index 0b3e2486f988d..0edee31913d1f 100644
--- a/fs/ext4/ioctl.c
+++ b/fs/ext4/ioctl.c
@@ -380,7 +380,9 @@ static int ext4_ioctl_setproject(struct file *filp, __u32 projid)
 		brelse(iloc.bh);
 	}
 
-	dquot_initialize(inode);
+	err = dquot_initialize(inode);
+	if (err)
+		return err;
 
 	handle = ext4_journal_start(inode, EXT4_HT_QUOTA,
 		EXT4_QUOTA_INIT_BLOCKS(sb) +