From: Nathan Chancellor Date: Thu, 24 Feb 2022 21:10:34 +0000 (-0700) Subject: iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=185897d03ca3c4c98eff5cbf151671c5f88165fb;p=linux.git iio: accel: adxl367: Fix handled initialization in adxl367_irq_handler() Clang warns: drivers/iio/accel/adxl367.c:887:2: error: variable 'handled' is uninitialized when used here [-Werror,-Wuninitialized] handled |= adxl367_push_event(indio_dev, status); ^~~~~~~ drivers/iio/accel/adxl367.c:879:14: note: initialize the variable 'handled' to silence this warning bool handled; ^ = 0 1 error generated. This should have used '=' instead of '|='; make that change to resolve the warning. Fixes: cbab791c5e2a ("iio: accel: add ADXL367 driver") Link: https://github.com/ClangBuiltLinux/linux/issues/1605 Reported-by: kernel test robot Reported-by: Colin Ian King Signed-off-by: Nathan Chancellor Link: https://lore.kernel.org/r/20220224211034.625130-1-nathan@kernel.org Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/accel/adxl367.c b/drivers/iio/accel/adxl367.c index bdc95409abed9..62960134ea195 100644 --- a/drivers/iio/accel/adxl367.c +++ b/drivers/iio/accel/adxl367.c @@ -884,7 +884,7 @@ static irqreturn_t adxl367_irq_handler(int irq, void *private) if (ret) return IRQ_NONE; - handled |= adxl367_push_event(indio_dev, status); + handled = adxl367_push_event(indio_dev, status); handled |= adxl367_push_fifo_data(indio_dev, status, fifo_entries); return handled ? IRQ_HANDLED : IRQ_NONE;