From: Nicolai Stange Date: Sun, 22 Jul 2018 11:38:18 +0000 (+0200) Subject: x86/KVM/VMX: Don't set l1tf_flush_l1d from vmx_handle_external_intr() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=18b57ce2eb8c8b9a24174a89250cf5f57c76ecdc;p=linux.git x86/KVM/VMX: Don't set l1tf_flush_l1d from vmx_handle_external_intr() For VMEXITs caused by external interrupts, vmx_handle_external_intr() indirectly calls into the interrupt handlers through the host's IDT. It follows that these interrupts get accounted for in the kvm_cpu_l1tf_flush_l1d per-cpu flag. The subsequently executed vmx_l1d_flush() will thus be aware that some interrupts have happened and conduct a L1d flush anyway. Setting l1tf_flush_l1d from vmx_handle_external_intr() isn't needed anymore. Drop it. Signed-off-by: Nicolai Stange Signed-off-by: Thomas Gleixner --- diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c index 33892ddd229ff..c6594fe384374 100644 --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -9983,7 +9983,6 @@ static void vmx_handle_external_intr(struct kvm_vcpu *vcpu) [ss]"i"(__KERNEL_DS), [cs]"i"(__KERNEL_CS) ); - vcpu->arch.l1tf_flush_l1d = true; } } STACK_FRAME_NON_STANDARD(vmx_handle_external_intr);