From: Markus Elfring <elfring@users.sourceforge.net> Date: Tue, 3 Sep 2019 12:40:18 +0000 (+0200) Subject: ext2: Delete an unnecessary check before brelse() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=18c2433cb8af4938bee01a766a2389f80e73d4ae;p=linux.git ext2: Delete an unnecessary check before brelse() The brelse() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Link: https://lore.kernel.org/r/51dea296-2207-ebc0-bac3-13f3e5c3b235@web.de Signed-off-by: Jan Kara <jack@suse.cz> --- diff --git a/fs/ext2/super.c b/fs/ext2/super.c index 44eb6e7eb492f..f4d5c624c4dc4 100644 --- a/fs/ext2/super.c +++ b/fs/ext2/super.c @@ -162,8 +162,7 @@ static void ext2_put_super (struct super_block * sb) } db_count = sbi->s_gdb_count; for (i = 0; i < db_count; i++) - if (sbi->s_group_desc[i]) - brelse (sbi->s_group_desc[i]); + brelse(sbi->s_group_desc[i]); kfree(sbi->s_group_desc); kfree(sbi->s_debts); percpu_counter_destroy(&sbi->s_freeblocks_counter);